This repository was archived by the owner on Jun 13, 2020. It is now read-only.
Remove 1d1 (Illogical die configuration).#221
Open
infoburp wants to merge 2 commits into
Open
Conversation
Author
|
There are other problems, for example "dice 0.1d0.1" is considered valid. I'll take a better look at this over the next few hours.. |
Author
|
Thanks for the feedback in your stream, Fredrick. As is this patch works (prevents 1d1), but it still accepts silly inputs like 1d1.1. I'm just setting up a local testing server so I can submit good code, and I'm happy to open another PR if/when you accept/close this one. |
Author
|
As I said in the stream, my next PR will hopefully modify more than 1 char... |
Update to latest 8ch code
Contributor
|
The code says it "intifies" the numbers, so decimals shouldn't be a problem. |
Author
|
Ok, but a one sided die still makes no logical sense, as it always returns 1... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1d2 is a coin, but 1d1 is a pointless die, as it always has the same result (1).